Refs #37179 - explicitly include SelectiveClone in facets

[evgeni]

That way plugins that try to use Hostgroup.include don't fail with

undefined method `include_in_clone' for Hostgroup

[evgeni]

I've verified this unblocks nightly using packit:

% ansible-playbook pipelines/install_pipeline.yml -e pipeline_os=centos9-stream -e pipeline_version=nightly -e pipeline_type=foreman -e '{"packit_prs":["theforeman/foreman/10084"]}'                          
…
TASK [bats : Run bats] ********************************************************************************************************************************
changed: [pipe-foreman-server-nightly-centos9-stream] => (item=fb-verify-packages.bats)
changed: [pipe-foreman-server-nightly-centos9-stream] => (item=fb-test-foreman.bats)
changed: [pipe-foreman-server-nightly-centos9-stream] => (item=fb-test-puppet.bats)
changed: [pipe-foreman-server-nightly-centos9-stream] => (item=fb-test-backup.bats)
changed: [pipe-foreman-server-nightly-centos9-stream] => (item=fb-verify-selinux.bats)
…
TASK [bats : Output test results] *********************************************************************************************************************************
ok: [pipe-foreman-server-nightly-centos9-stream] => 
  msg: |-
    1..1
    ok 1 centos9-stream install: verify no rh-ruby24, rh-ruby25, tfm-ror51 or tfm-ror52 SCL packages # skip SCL package checks only applicable on EL 7 systems
    1..5
    ok 1 centos9-stream install: assert correct Foreman version is installed # skip FOREMAN_EXPECTED_VERSION is not set, not asserting
    ok 2 centos9-stream install: check service status
    ok 3 centos9-stream install: check web app is up
    ok 4 centos9-stream install: check hammer ping
    ok 5 centos9-stream install: check smart proxy is registered
    1..11
    ok 1 centos9-stream install: enable puppet feature # skip Enabling Puppet explicitly is only needed with Katello 4.3+
    ok 2 centos9-stream install: check smart proxy is registered
    ok 3 centos9-stream install: assert puppet version
    ok 4 centos9-stream install: wake up puppet agent
    ok 5 centos9-stream install: check host is registered
    ok 6 centos9-stream install: install puppet module
    ok 7 centos9-stream install: import motd puppet class
    ok 8 centos9-stream install: assign puppet-environment to default taxonomies
    ok 9 centos9-stream install: assign puppet class to host
    ok 10 centos9-stream install: apply class with puppet agent
    ok 11 centos9-stream install: ensure there is a report for Puppet
    1..7
    ok 1 centos9-stream install: prepare system
    ok 2 centos9-stream install: perform offline backup
    ok 3 centos9-stream install: check offline backup contests for Foreman
    ok 4 centos9-stream install: check offline backup contents for Katello # skip Katello specific test
    ok 5 centos9-stream install: perform online backup
    ok 6 centos9-stream install: check online backup contests for Foreman
    ok 7 centos9-stream install: check online backup contents for Katello # skip Katello specific test
    1..1
    ok 1 centos9-stream install: ensure no SELinux denials
…

[sbernhard]

Actually, my productive system with #10055 did not break but appliying this PR didn't cause another issue. So, would be happy to merge this. :-)

[evgeni]

Actually, my productive system with #10055 did not break

Which plugins are installed? This only happens if you have a plugin that does smth like Hostgroup.include ForemanPuppet::Extensions::Hostgroup (and that extension uses include_in_clone?)

[sbernhard]

Actually, my productive system with #10055 did not break

Which plugins are installed? This only happens if you have a plugin that does smth like Hostgroup.include ForemanPuppet::Extensions::Hostgroup (and that extension uses include_in_clone?)

I have foreman_puppet running:

models/concerns/foreman_puppet/extensions/host.rb:        include_in_clone puppet: %i[config_groups host_config_groups host_classes]
models/concerns/foreman_puppet/extensions/hostgroup.rb:        include_in_clone puppet: %i[host_config_groups config_groups hostgroup_classes]

[evgeni]

Interesting. Once I install foreman_ansible on my reproducer, it does not reproduce this issue anymore.

[ShimShtein]

Merged, thanks @evgeni !