Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #37224 - Force *all* Hosts to have a comment #10086

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

adamruzicka
Copy link
Contributor

@adamruzicka adamruzicka commented Mar 11, 2024

The previous implementation of the update had two issues:

  1. It only operated on ::Host::Managed
  2. It silently failed if the host was invalid for any other reason

Fixes 4c7f36e

The previous implementation of the update had two issues:
1) It only operated on ::Host::Managed
2) It silently failed if the host was invalid for any other reason

Fixes 4c7f36e
Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all!

@ofedoren ofedoren merged commit dd5091f into theforeman:develop Mar 11, 2024
39 of 40 checks passed
@adamruzicka adamruzicka deleted the comment branch March 11, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants