Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37244: Add new virtual hw versions for VSphere 8.0 and 8.0U2 #10090

Merged
merged 1 commit into from Mar 14, 2024

Conversation

Areyus
Copy link

@Areyus Areyus commented Mar 12, 2024

@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

2 similar comments
@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

@Areyus Areyus marked this pull request as draft March 12, 2024 13:38
@Areyus
Copy link
Author

Areyus commented Mar 12, 2024

Disclaimer: I do not currently have a VSphere 8 instance around to test this myself, so I ask ksiminski, who originally reported this, for tests: https://community.theforeman.org/t/update-for-vmware-hardware-version/37242

@Odilhao
Copy link
Member

Odilhao commented Mar 12, 2024

ok to test

@stejskalleos stejskalleos self-assigned this Mar 13, 2024
@Areyus
Copy link
Author

Areyus commented Mar 13, 2024

Rebased on top of current develop to fix unrelated test failures

Copy link

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, Thanks @Areyus , I've tested this on VCenter 8, and we now see virtual H/W versions 21 (ESXi 8.0 U2) and 20 (ESXi 8.0)
I also tested the provisioning with these virtual hardware versions and it worked.

Screenshot 2024-03-13 at 5 38 32 PM

@stejskalleos stejskalleos marked this pull request as ready for review March 14, 2024 08:20
@stejskalleos stejskalleos merged commit 639910b into theforeman:develop Mar 14, 2024
40 checks passed
@stejskalleos
Copy link
Contributor

Thanks @Areyus @Gauravtalreja1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants