Fixes #36023: Add missing VMWare GuestOS mappings #10092
Conversation
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
I was not able to test this directly myself, since I am currently missing the required infrastructure. but I confirmed all used identifiers match with the current rbvmomi2 release and all known values from rbvmomi2 are also present in Foreman. |
|
ok to test |
There was a problem hiding this comment.
I think this looks good and I can verify we now have descriptions for everything.
We can get the missing items with rake console and print RbVmomi::VIM::VirtualMachineGuestOsIdentifier.values - Foreman::Model::Vmware.new.guest_types_descriptions.keys.
On develop:
["windows11_64Guest",
"windows12_64Guest",
"windows2019srv_64Guest",
"windows2019srvNext_64Guest",
"windows2022srvNext_64Guest",
"freebsd13Guest",
"freebsd13_64Guest",
"freebsd14Guest",
"freebsd14_64Guest",
"oracleLinux9_64Guest",
"sles16_64Guest",
"debian11Guest",
"debian11_64Guest",
"debian12Guest",
"debian12_64Guest",
"asianux9_64Guest",
"other5xLinuxGuest",
"other6xLinuxGuest",
"other5xLinux64Guest",
"other6xLinux64Guest",
"darwin19_64Guest",
"darwin20_64Guest",
"darwin21_64Guest",
"darwin22_64Guest",
"darwin23_64Guest",
"vmkernel7Guest",
"vmkernel8Guest",
"amazonlinux2_64Guest",
"amazonlinux3_64Guest",
"crxPod1Guest",
"rockylinux_64Guest",
"almalinux_64Guest"]
On this branch:
[]
And all descriptions match the docs.
|
Tests are still running now, but otherwise 👍 to merging. |
This brings Foreman's GuestOSIdentifier mapping up to date with rbvmomi2 3.7 and VSphere 8.0U2