Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #37248 - make hostsIndexContext a singleton #10094

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Fixes #37248 - make hostsIndexContext a singleton #10094

merged 1 commit into from
Mar 13, 2024

Conversation

MariaAga
Copy link
Member

No description provided.

@github-actions github-actions bot added the UI label Mar 13, 2024
jeremylenz
jeremylenz previously approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, nice find @MariaAga :)

needs eslint --fix

ofedoren
ofedoren reviewed Mar 13, 2024
View reviewed changes
Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint failures :/

@MariaAga
Copy link
Member Author

Thanks both :) fixed!

@jeremylenz
Copy link
Contributor

Needs a rebase to fix the unrelated failures

@MariaAga MariaAga closed this Mar 13, 2024
@MariaAga MariaAga reopened this Mar 13, 2024
@jeremylenz jeremylenz merged commit 46fcd9a into theforeman:develop Mar 13, 2024
56 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofedoren ofedoren ofedoren left review comments

@jeremylenz jeremylenz jeremylenz approved these changes

Assignees
No one assigned
Labels
UI
Projects
None yet
Milestone
No milestone
3 participants
@MariaAga @jeremylenz @ofedoren