Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37280 - remove typeAheadSelect #10101

Merged
merged 1 commit into from Apr 5, 2024

Conversation

MariaAga
Copy link
Member

Just noticed it when going over our code that nothing uses it anymore.
Searched all foreman & katello org and didnt find anything, also searched "import typeAheadSelect foremanReact" in github and found nothing.

Copy link
Contributor

@kmalyjur kmalyjur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I also couldn't find it used anywhere and everything seems to be deleted as it should

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the last use in Foreman was removed in 0b167ac which is quite some time ago. I can't find any traces either so 👍 to cleaning up.

@ekohl
Copy link
Member

ekohl commented Apr 5, 2024

JS tests look unrelated and it's simply coveralls complaining. Probably something we should address, but not here.

@ekohl ekohl merged commit 1b215f6 into theforeman:develop Apr 5, 2024
51 of 54 checks passed
@jeremylenz
Copy link
Contributor

Hey! Katello needed that.. 😄

@MariaAga
Copy link
Member Author

Removing it from Katello so it wont be a problem :) @jeremylenz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants