Fixes #37292 - Deal with curl error codes when registering hosts #10109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curl could fail to make the POST request and the registration would still appear as successful.
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
ekohl
reviewed
Mar 22, 2024
| @@ -106,7 +106,8 @@ fi | |||
| <% end -%> | |||
|
|
|||
| register_host() { | |||
| curl --silent --show-error --cacert $SSL_CA_CERT --request POST <%= @registration_url %> \ | |||
| CURL_OUT=$(mktemp) | |||
| HTTP_RETURN_CODE=$(curl --silent --output $CURL_OUT --write-out "%{http_code}" --cacert $SSL_CA_CERT --request POST <%= @registration_url %> \ | |||
There was a problem hiding this comment.
Any reason not to use --fail? It's available on EL7. Perhaps not on EL6?
There was a problem hiding this comment.
I didn't try it because: Fail silently (no output at all) and I wanted to show the error output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
curl could fail to make the POST request and the registration would still appear as successful.