Fix #37289 - Download report template created in less than 24 hours [WIP] #10111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
ares
reviewed
Mar 28, 2024
There was a problem hiding this comment.
Thanks @waldirio for the initial draft. I'm sure the code can be cleaned up a bit, but this is a great POC to agree on the way we fetch the data.
I think that it currently ignores who generated the report, correct? Like user A generates the report, user B can see it. That may be security issue, because the report IIRC is rendered in scope of the user, so each user may get different data from it. This is definitely the case for the reports which contain the load_...() macro.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is still working in progress, @ares let me know what you think, and I'm pretty sure that we can improve this code.
At this moment, it's working as expected, once there is a report in the stored_values table, and some of the information matches, the link will be presented on the report template page.
Thank you!
Waldirio