Fixes #37374 - Prefer execution interface over primary #10136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we can expose it: https://github.com/theforeman/foreman/blob/develop/config/initializers/safemode_jail.rb#L27 |
adamruzicka
force-pushed
the
ansible-inventory
branch
from
042216a
to
f392991
Compare
ekohl
reviewed
Apr 25, 2024
Comment on lines
180
to
182
| inventory_data.update('ipv4': net_sources.find { |s| s.ip }&.ip) if input_ipv4 | ||
| inventory_data.update('ipv6': net_sources.find { |s| s.ip6 }&.ip6) if input_ipv6 | ||
| inventory_data.update('subnet': net_sources.find { |s| s.subnet }&.subnet) if input_subnet |
There was a problem hiding this comment.
Thinking out loud: can it happen that you have an ip that comes from the execution interface but the subnet that comes from the host? Wouldn't that be confusing? Same for ip6 & subnet6 of course.
ekohl
approved these changes
Apr 26, 2024
|
Will you squash the commits? |
in Ansible Inventory report template. The execution interface method is not defined (and exposed in safemode jail) unless remote execution plugin is enabled.
adamruzicka
force-pushed
the
ansible-inventory
branch
from
dca35c5
to
db0ccb9
Compare
|
Took the liberty of merging this myself since it was approved some time ago. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in Ansible Inventory report template.
The execution interface method is not defined (and exposed in safemode jail) unless remote execution plugin is enabled.
It could have been a bit nicer if safemode exposed Array#find