Fixes #37385 - Drop (un)check_all_roles event handlers #10141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Legacy JS
|
I'm not sure what we should do with the commits. Shall I open separate issues for them? |
MariaAga
approved these changes
Apr 25, 2024
In acfbc45 the links with these IDs were removed, but the JavaScript handler remained. I can't find other traces of its usage. Originally added in feacea3. Fixes: acfbc45 ("fixes theforeman#812 - new permissions model, user group role and nest support, role filters for better granularity")
Their last use was dropped in acfbc45 and I can't other traces of their usage. Fixes: acfbc45 ("fixes theforeman#812 - new permissions model, user group role and nest support, role filters for better granularity")
ekohl
force-pushed
the
37385-drop-check-roles
branch
from
5bb3c85
to
1a6c42e
Compare
|
Because it's changing the same file I submitted it within one PR, with multiple commits. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In acfbc45 the links with these IDs were removed, but the JavaScript handler remained. I can't find other traces of its usage. Originally added in feacea3.
Fixes: acfbc45 ("fixes #812 - new permissions model, user group role and nest support, role filters for better granularity")