Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37421 - foreman_bootdisk templates not seeded #10151

Merged
merged 1 commit into from
May 14, 2024

Conversation

stejskalleos
Copy link
Contributor

Remove some strange characters at the beginning of the version line, which were blocking the seed of the templates.

Remove some strange characters at the beginning of the version line,
which were blocking the seed of the templates.
@@ -7,7 +7,7 @@ description: |
Boot disk Grub2 EFI - generic host
require:
- plugin: foreman_bootdisk
 version: 20.0.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChatGPT explanation:

The strange character you're seeing, "�" or "", is known as the Replacement Character or Object Replacement Character.

Object Replacement Character (): In Unicode, it's represented as U+FFFC. It stands for "Object Replacement Character" and is often seen when non-textual objects (like images or symbols) are replaced.

Possible Causes
Copy-Pasting Issues:
When text is copied from a document or website with non-standard encoding and pasted into code, the character might be inserted.
Editor Encoding:
Different editors may use different default encodings. If one editor writes files in one encoding (e.g., UTF-16), and another editor tries to read it in another encoding (e.g., UTF-8), you might see replacement characters.
Encoding Mismatch:
If files are transferred or read using different encodings than the original, the data might not translate correctly.
Corrupted Files:
Binary or other non-textual data can sometimes end up in text files due to corruption.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes b76abb6, so a regression introduced in Foreman 3.4.

I question the original logic. Why don't we have plugin templates within the plugin itself? There's no reasoning at all in the Redmine issue or original PR.

@stejskalleos
Copy link
Contributor Author

stejskalleos commented May 13, 2024

One reason was to have all the templates in one place, which could make contributions from the community a bit easier.

I believe deprecating the foreman_templates was also a thing.

@ekohl
Copy link
Member

ekohl commented May 13, 2024

Do you mean community-templates? The forean_templates plugin is useful to export your local changes to git as well as import them.

This is why I always push people to write it down. Reconstructing t later is always hard

@stejskalleos
Copy link
Contributor Author

No matter what the original reason was, can we get this?

@ekohl ekohl merged commit 4907a96 into theforeman:develop May 14, 2024
52 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants