Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hostgroup bulk actions : Reassign hostgroups #10202

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Hostgroup bulk actions : Reassign hostgroups #10202

merged 1 commit into from
Jul 12, 2024

Conversation

sjha4
Copy link
Contributor

@sjha4 sjha4 commented Jun 10, 2024 •
edited
Loading

  • Build select dropdown for hostgroups for reassignment

@github-actions github-actions bot added the UI label Jun 10, 2024
@sjha4 sjha4 force-pushed the hostgroup_bulk_actions branch 2 times, most recently from f819ec7 to 68d093a Compare June 10, 2024 19:10
@sjha4 sjha4 marked this pull request as ready for review June 10, 2024 19:10
@sjha4 sjha4 force-pushed the hostgroup_bulk_actions branch 3 times, most recently from 468dcf1 to f5374b6 Compare June 11, 2024 13:53
jeremylenz
jeremylenz reviewed Jun 11, 2024
View reviewed changes
Copy link
Contributor

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;)

webpack/assets/javascripts/react_app/components/HostsIndex/index.js Outdated Show resolved Hide resolved
@sjha4 sjha4 force-pushed the hostgroup_bulk_actions branch 2 times, most recently from b917a2c to 369ba65 Compare June 17, 2024 20:21
@jeremylenz
Copy link
Contributor

I tried to unset the hostgroup (by leaving the selection blank) and got this:
image

@sjha4
Copy link
Contributor Author

sjha4 commented Jul 10, 2024

Updated to add typeahead to select dropdown and address other reviews.

@sjha4 sjha4 force-pushed the hostgroup_bulk_actions branch 2 times, most recently from fca9a7c to 9ea0843 Compare July 10, 2024 19:05
@sjha4 sjha4 force-pushed the hostgroup_bulk_actions branch 2 times, most recently from 94e15e9 to 2e138a4 Compare July 11, 2024 16:51
jeremylenz
jeremylenz approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with both old and new page. Hostgroups are assigned as expected.

also translations look good now 👍

Thanks @sjha4! ACK

ekohl
ekohl reviewed Jul 12, 2024
View reviewed changes
app/controllers/api/v2/hosts_bulk_actions_controller.rb
@@ -63,6 +63,21 @@ def build
end
end

api :PUT, "/hosts/bulk/reassign_hostgroups", N_("Reassign hostgroups")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REST API wise I think POST /hostgroups/:id/hosts would be cleaner but I see the bulk pattern is already established so I'm not going to block on this.

@ekohl ekohl dismissed their stale review July 12, 2024 13:40

Translation issues were addressed

@jeremylenz jeremylenz merged commit f824a88 into theforeman:develop Jul 12, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@jeremylenz jeremylenz jeremylenz approved these changes

Assignees

@jeremylenz jeremylenz

@ofedoren ofedoren

Labels
UI
Projects
None yet
Milestone
No milestone
4 participants
@sjha4 @jeremylenz @ekohl @ofedoren