Fixes #37575 - Foreman Table columns sort is inconsistent

[MariaAga]

To test you can open the models table in firefox and chrome and see that the order is different before the pr.
Firefox and Chrome implement the sort function differently

[ekohl]

What if both weights are undefined? Should it sort on a secondary parameter like name or id?

[MariaAga]

then it sorts it in the order the columns are in the object provided to the table

[ekohl]

Shouldn't it still return 0 if both are undefined? Because then you can consider them equal.

[MariaAga]

It will return 0 if both undefined since then the first if would be true columnBWeight === undefined

[ekohl]

What I meant was that it needs to be:

if (columnAWeight === undefined && columnBWeight === undefined) {
        return 0;
}
if (columnBWeight === undefined) {
        return -1;
}
if (columnAWeight === undefined) {
        return 1;
}
return columnAWeight - columnBWeight;

Because the sort interface says that when it's 0 they should be considered equal. Your current change implies that if columnBWeight they're always equal, even if columnAWeight isn't undefined.

Another way to look at it is that the function should be its inverse with a swapped order, or sort(a, b) == -sort(b, a).

[MariaAga]

Yeah changed to this logic instead, the weights are sorted in this way, from the doc:

• weight - the weight of the column, which determines the order in which columns are displayed. Lower weights are displayed first.

[ekohl]

@jeremylenz since I proposed the current version, would you mind reviewing?

[jeremylenz]

Tested and LGTM 👍