Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] VMware - Secure Boot & Virtual TPM #10225

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

stejskalleos
Copy link
Contributor

Add support for Secure Boot and TPM
Inspired by https://github.com/ananace/foreman_vmware_advanced
Required FOG PR: fog/fog-vsphere#301

@stejskalleos stejskalleos changed the title VMware - Secure Boot & Virtual TPM [WIP] VMware - Secure Boot & Virtual TPM Jun 27, 2024
@stejskalleos stejskalleos marked this pull request as draft June 27, 2024 08:11
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, looks like tests are failing since we don't have fog-vsphere built with your change.

@@ -49,6 +49,16 @@ end %>
{ :disabled => images.empty?, :label => _('Image'), :label_size => "col-md-2" } %>
</div>

<%= checkbox_f f, :secure_boot, { :help_inline => _("Enable Secure Bott for provisioning."),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<%= checkbox_f f, :secure_boot, { :help_inline => _("Enable Secure Bott for provisioning."),
<%= checkbox_f f, :secure_boot, { :help_inline => _("Enable Secure Boot for provisioning."),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants