Fixes #37614 - Use SHA512 for password hashing when no OS is set #10231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In e2dee7d the default for new operating systems was changed to SHA512, but there's an edge case where no is know for a host that makes it use SHA256. SHA512 has been the recommended value for hashing since EL5 and at least in EL6 it was also the default (didn't have EL5 on hand to check /etc/login.defs).
ekohl
force-pushed
the
37614-default-hash-algorhitm
branch
from
0151ddb
to
50a2a0d
Compare
evgeni
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In e2dee7d the default for new operating systems was changed to SHA512, but there's an edge case where no is know for a host that makes it use SHA256.
SHA512 has been the recommended value for hashing since EL5 and at least in EL6 it was also the default (didn't have EL5 on hand to check /etc/login.defs).