Fixes #37627 - Only update repositories once in global registration #10237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using shell to compose a file, this uses ERB to determine the content once.
Rather than doing this for each repository, it is now performed once.
| @@ -98,13 +96,18 @@ elif [ -f /etc/debian_version ]; then | |||
| curl --silent --show-error --output /etc/apt/trusted.gpg.d/client<%= index %>.asc <%= shell_escape repo_gpg_key_url %> | |||
| fi | |||
| <% end -%> | |||
| apt-get update | |||
|
|
|||
| else | |||
| echo "Unsupported operating system, can't add repository." | |||
| cleanup_and_exit 1 | |||
| fi | |||
There was a problem hiding this comment.
Suggested change
| fi | |
| fi | |
While you are at it, you could add a newline such that the code blocks that configure a repository will be separated by a newline in the resulting shell script.
nadjaheitmann
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than doing this for each repository, it is now performed once.
It also simplifies writing out the repo file to make the write atomic. Right now it doesn't use
save_to_file, but that could simplify it even further.