Fixes #37644 - Pagination doesnt update between react pages

[MariaAga]

To recreate the bug: navigate to models?search=&page=2&per_page=5
from the menu, go to audits, then from the menu go to models
result is that the page will show page 1, per page 20 results from the api, but the pagination ui will show page 2, per page 5.
if the search is not empty, params.get('page') won't always be there, so the code sets the default value

[ekohl]

It's confusing to me that there's a certain overlap between this and

foreman/webpack/assets/javascripts/react_app/components/PF4/TableIndexPage/TableIndexPage.js

Lines 115 to 128 in e78bd15

	const urlParams = new URLSearchParams(historySearch);
	const urlParamsSearch = urlParams.get('search') || '';
	const search = urlParamsSearch || getURIsearch();
	const defaultParams = { search: search || '' };
	if (updateParamsByUrl) {
	const urlPage = urlParams.get('page');
	const urlPerPage = urlParams.get('per_page');
	if (urlPage) {
	defaultParams.page = parseInt(urlPage, 10);
	}
	if (urlPerPage) {
	defaultParams.per_page = parseInt(urlPerPage, 10);
	}
	}

It makes me question: why does the front end hardcode a per_page default? Shouldn't it just make an API request and read the per_page value from the result? That way it respects the default settings.

[ekohl]

On line 34 there's perPage. Why isn't that used?

[MariaAga]

line 34 is: const [perPage, setPerPage] = useState(propsPerPage || settingsPerPage);
and then later in this useeffect theres setPerPage(current => nextPerPage || current || settingsPerPage);

[MariaAga]

It makes me question: why does the front end hardcode a per_page default? Shouldn't it just make an API request and read the per_page value from the result? That way it respects the default settings

I think the code snippet you gave, is the one to prepage the page param before the api request, to know which page to request based on the url, so if the url is models?search=&page=2&per_page=5, request only 5 per_page

[kmalyjur]

Awesome, now it works as it should

[jeremylenz]

from the menu, go to audits, then from the menu go to models
result is that the page will show page 1, per page 20 results from the api, but the pagination ui will show page 2, per page 5.

When I do this on develop, I get the behavior above.
After checking out the pr, I get behavior that is better but still not correct: It seems like the pagination shows a correct page of 1 but an incorrect perPage:

"1-5 of 10" but it still shows all 10. (My default per page setting is unchanged from the default of 20.)

[MariaAga]

Thanks @jeremylenz added another condition to make sure the value is correct

[jeremylenz]

Works well now 👍

thanks @MariaAga!

[jeremylenz]

Ruby Katello failures unrelated; merging.