Fixes #37645 - Tab title missing in tableindexpage #10242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeremylenz / @parthaa could you take a look? |
kmalyjur
approved these changes
Aug 7, 2024
| @param {string}{headerText} - the header text for the page | ||
| @param {string}{header} - header node; default is <title>{headerText}</title> | ||
| @param {React.ReactNode}{customHeader} - a custom header to be rendered instead of the default header | ||
| @param {string}{headerText} - DEPRECATED - the header text for the page |
There was a problem hiding this comment.
Can't we delete the headerText?
There was a problem hiding this comment.
no since its used in Katello: https://github.com/Katello/katello/blob/master/webpack/components/extensions/Hosts/BulkActions/HostReview.js#L125
jeremylenz
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helmet (from Head) sends its children directly to the head tag, so it doesnt make sense to send it text.
title html tag defines the title of the tab, and should only be used in the head.
The change in #9878 broke some table pages that now dont have a title, like hardware models, since it using
headerasheaderText.