fixes #3493 - check if auto user reg is allowed for auth source #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is checking of onthefly_register in auth_source_ldap but this is faulty. The user is auto-created created, just without any information like name, e-mail, etc. because of this: https://github.com/theforeman/foreman/blob/develop/app/models/auth_sources/auth_source_ldap.rb?#L112 I think try_to_auto_create_user method is the better place to check anyway? |
|
[test] |
| @@ -0,0 +1,8 @@ | |||
| class AuthSourceDummy < AuthSource | |||
|
|
|||
| def authenticate(login, password) | |||
There was a problem hiding this comment.
This should move into a fixture / test/ mocking etc?
There was a problem hiding this comment.
Yes... I hadn't worked with ruby mocking/stubbing before but it was easier than I thought. I also added logging when authentication succeeds but the user isn't auto-created.
Is that better?
|
[test] |
|
Can you retest? Rebased because of #1036 |
|
[test] |
1 similar comment
|
[test] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
source.onthefly_register wasn't checked anywhere, so ldap users were always automatically registered.