fixes #3752 - move data population from migrations into seed script #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I've got some tests to fix, but otherwise open for review. Probably won't get to that until next week now. |
|
|
||
| def up | ||
| CONFIG_RENAMES.each do |old,new| | ||
| ConfigTemplate.find_by_name(old).try(:update_attributes, :name => new) |
There was a problem hiding this comment.
I assume that try does not fail when update fails. Nice.
There was a problem hiding this comment.
update_attributes will simply return false if update fails
|
Thanks for the previous review comments, PR's updated for review. |
|
LGTM Nice work. |
|
Thanks, rebased so hopefully the tests pass. |
| @@ -12,7 +12,7 @@ def self.up | |||
| updated = [] | |||
| email = SETTINGS[:administrator] || "root@#{Facter.domain}" | |||
| owner = User.find_by_mail email | |||
| owner ||= User.find_or_create_by_login(:login => "admin", :admin => true, :firstname => "Admin", :lastname => "User", :mail => email) | |||
| owner ||= User.where(:admin => true).first | |||
There was a problem hiding this comment.
nm, i see you re-defined user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks more severe than it is I think.
I think this is more reliable than the DB migrations. I was beginning to implement improved admin account initialisation and the use of DB migrations was hampering me, as they have to support both upgrades and initial installations - they're quite fragile as a result.