Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #2600 - fixed gettext extraction on vms forms #1079

Closed
wants to merge 2 commits into from
Closed

fixes #2600 - fixed gettext extraction on vms forms #1079

wants to merge 2 commits into from

Conversation

lzap
Copy link
Member

@lzap lzap commented Dec 6, 2013

Please someone take this PR and finish this as I was not able to test with the
following CRs:

  • EC2
  • GCE
  • oVirt
  • Vmware

I tried my best to fake it, giving up.

@domcleal
Copy link
Contributor

domcleal commented Dec 6, 2013

I've sent lzap#5 to finish it off, but can't test GCE at the moment.

@lzap
Copy link
Member Author

lzap commented Dec 6, 2013

Merged, commit message reworded.

Thanks!

LZ

On Fri, Dec 06, 2013 at 03:48:49AM -0800, Dominic Cleal wrote:

I've sent lzap#5 to finish it off, but can't test GCE at the moment.

Reply to this email directly or view it on GitHub:
#1079 (comment)

Later,

Lukas "lzap" Zapletal
irc: lzap #theforeman

@domcleal
Copy link
Contributor

domcleal commented Dec 9, 2013

Thanks @lzap, merged as a0c1773.

@domcleal domcleal closed this Dec 9, 2013
@lzap lzap deleted the gettext-vms-2600 branch July 23, 2014 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lzap @domcleal