fixes #2794 - set api_version and app_info in v1 and v2 base_controllers #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,7 +5,7 @@ class BaseController < Api::BaseController | |||
|
|
|||
| resource_description do | |||
| api_version "v1" | |||
| api_version "v2" | |||
| app_info "Foreman v1 is currently in the default API version." | |||
There was a problem hiding this comment.
if app_info is not set, then it generates in the docs
Another API description
There was a problem hiding this comment.
"Foreman v1 is currently the default API version." makes more sense
There was a problem hiding this comment.
@domcleal, you're right. I will fire my proofreader (uh oh, that's me :-). I'll regenerate the docs too
|
merged as af8d606, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.