fixes #4021 - upgrade to Rails 3.2.16 #1154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The packages are going to need to be built in Koji, too. @isratrade do you want to take a shot at doing that? I think this PR should wait until after the first RC drops because it might hold up getting RC's out the door. |
|
We won't build these in koji because we use RHSCL, that'll remain on 3.2.8. |
|
Whoops, right. There are some failing tests and I'm not sure whether they're related to the PR, but I see activerecord in the stacktrace so I'm rerunning the tests to know for sure. [test] |
|
no problem to wait on merging this PR |
|
Merged as eccf81a for Foreman 1.4, thanks @isratrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.