Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Environment name to rundeck output #1274

Closed
wants to merge 2 commits into from
Closed

Added Environment name to rundeck output #1274

wants to merge 2 commits into from

Conversation

abohne
Copy link

@abohne abohne commented Mar 5, 2014

This simple change adds Environment: environment_name to the output consumed by rundeck.

@domcleal
Copy link
Contributor

domcleal commented Mar 5, 2014

[test]

@@ -518,6 +518,7 @@ def rundeck
rdecktags += self.params["rundeckfacts"].gsub(/\s+/, '').split(',').map { |rdf| "#{rdf}=" + (facts_hash[rdf] || "undefined") }
end
{ name => { "description" => comment, "hostname" => name, "nodename" => name,
"Environment" => Environment.find(self.environment_id).name,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can simplify this without a separate lookup, simply by doing "Environment" => environment.name

@abohne
Copy link
Author

abohne commented Mar 6, 2014

Thanks for the pointer, I've made the suggested change.

@domcleal
Copy link
Contributor

domcleal commented Mar 7, 2014

[test]

@domcleal
Copy link
Contributor

domcleal commented Mar 7, 2014

Merged as 6a28461 for Foreman 1.5.0, thanks @abohne!

@domcleal domcleal closed this Mar 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants