Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change format validation for user:firstname and user:lastname #1387

Closed
wants to merge 1 commit into from
Closed

Change format validation for user:firstname and user:lastname #1387

wants to merge 1 commit into from

Conversation

xavier-calland
Copy link

Allow all except :cntrl: (allow accent, …)

Allow all except [:cntrl:] (allow accent, …)
@lzap
Copy link
Member

lzap commented Apr 18, 2014

Hello,

we have strict constraints on users for reasons - some plugins like Katello heavily realy on user names because these are handed over to backend systems like Pulp or Candlepin. I don't think we can accept that. Opinions? [test] @ehelms ?

@xavier-calland
Copy link
Author

In my case, the need is to have accents (é, ô, à, …) in firstname and lastname.

@thomasmckay
Copy link
Contributor

@lzap I would have expected that first and last names should support any i18n characters. This would be different than "username" which likely would have more restrictions.

Typically in katello if a backend service has character restrictions a "label" field will be added to the object. This allows the "name" fields to be any characters.

Hope that helps!

@lzap
Copy link
Member

lzap commented Apr 22, 2014

Oh yeah, sorry I misread the patch. First name and stuff is fine of course, thanks! [test]

@domcleal
Copy link
Contributor

A couple of tests are failing around test/unit/user_test.rb:52, could you take a look please?

@ghost
Copy link

ghost commented May 15, 2014

I have just tested this on our test host and it indeed does fix "Invalid Surname" errors for Users not being able to log in, if coming from LDAP and users Name/Surname is containing an UTF8 character.

@domcleal
Copy link
Contributor

I've submitted a new PR with tests: #1467

@domcleal domcleal closed this May 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants