fixes #5788 - before_destroy missing from EnsureNotUsedBy.new in SmartProxy model #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,7 @@ class SmartProxy < ActiveRecord::Base | |||
| audited :allow_mass_assignment => true | |||
|
|
|||
| attr_accessible :name, :url, :location_ids, :organization_ids | |||
| EnsureNotUsedBy.new(:hosts, :hostgroups, :subnets, :domains, :puppet_ca_hosts, :puppet_ca_hostgroups) | |||
| before_destroy EnsureNotUsedBy.new(:hosts, :hostgroups, :subnets, :domains, :puppet_ca_hosts, :puppet_ca_hostgroups) | |||
There was a problem hiding this comment.
realms too, come to think of it
There was a problem hiding this comment.
realm.rb has before_destroy
There was a problem hiding this comment.
right, but this line is checking that the proxy isn't used on another resource, so we should probably ensure it's not used by a realm too
There was a problem hiding this comment.
fixed and re-committed.
…ew in SmartProxy model
|
Merged as f20ddfe for Foreman 1.5.1, thanks @isratrade. |
ares
added a commit
to ares/foreman
that referenced
this pull request
Jul 7, 2015
ares
added a commit
to ares/foreman
that referenced
this pull request
Jul 7, 2015
ares
added a commit
to ares/foreman
that referenced
this pull request
Jul 10, 2015
ares
added a commit
to ares/foreman
that referenced
this pull request
Jul 15, 2015
ares
added a commit
to ares/foreman
that referenced
this pull request
Aug 5, 2015
ares
added a commit
that referenced
this pull request
Aug 5, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.