fixes #6333 - CSS float right for Admin Menu is not right justified on some browsers #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ustified on some browsers
| @@ -51,6 +51,7 @@ | |||
|
|
|||
| .navbar-outer { | |||
| height: 25px; | |||
| padding-bottom:25px; | |||
There was a problem hiding this comment.
Since the contents are float right, the height is essentially ignored. By adding padding, the div now has a "height". This fix is not needed on Chrome browsers, but there is an issue on some Mozilla browsers.
Note, the minimum for the fix was padding-bottom:22px. I added an extra 3px so that the gravatar isn't touching the bottom border line. Is this is desired, then I can change from 25px to 22px.
|
Could you please provide more information on the bug report? I can't tell what I'm reviewing for from the description. |
|
closing, not a bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.