fixes #3664 - support deletion of installation media that's in use #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM testing. |
|
WGFM |
|
Once unit tests shows green, this is ready to be merged. Nitpick: The error message shows "mediaXYZ is used by hostXYZ". The best experience would be to inform the user about that build mode. Less important. |
| @@ -4,11 +4,11 @@ class Medium < ActiveRecord::Base | |||
| include ValidateOsFamily | |||
| audited :allow_mass_assignment => true | |||
|
|
|||
| before_destroy EnsureNotUsedBy.new(:hosts, :hostgroups) | |||
| before_destroy :ensure_hosts_not_in_build | |||
There was a problem hiding this comment.
re-factored here to create custom message that "media is used by host in build mode"
|
It's not clear to me which katello tests fail. |
|
It timed out. [test] |
|
Merged as 08d248f for Foreman 1.6. Thank you @isratrade ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.