fixes #6432 - add validation for attributes missing :presence => true and remove duplicate validation messages 'can't be blank' #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,7 +22,8 @@ class ComputeResource < ActiveRecord::Base | |||
|
|
|||
| before_destroy EnsureNotUsedBy.new(:hosts) | |||
| has_and_belongs_to_many :users, :join_table => "user_compute_resources" | |||
| validates :name, :uniqueness => true, :format => { :with => /\A(\S+)\Z/, :message => N_("can't be blank or contain white spaces.") } | |||
There was a problem hiding this comment.
Could you add :required => true to :name in api/v2/compute_resources_controller.rb now that it's validated?
|
👍 for me, it's nearly done, just misses some changes in the API docs to match the presence validators. |
| @@ -22,7 +22,8 @@ class ComputeResource < ActiveRecord::Base | |||
|
|
|||
| before_destroy EnsureNotUsedBy.new(:hosts) | |||
| has_and_belongs_to_many :users, :join_table => "user_compute_resources" | |||
| validates :name, :uniqueness => true, :format => { :with => /\A(\S+)\Z/, :message => N_("can't be blank or contain white spaces.") } | |||
| validates :name, :presence => true, :uniqueness => true, | |||
| :format => { :with => /\A(\S+)\Z/, :message => N_("can't be blank or contain white spaces.") } | |||
There was a problem hiding this comment.
Can you double check the behaviour of error messages in case they're duplicated? I think you may see the Rails message about presence and our message saying it can't be blank if you leave the field blank.
|
wait to merge. fixing more attributres |
…ce => true and remove duplicate validation messages 'can't be blank'
|
re-committed after removing more "can't be blank" duplicate validation messages |
isratrade
changed the title
|
Merged as 4df26ec , thanks @isratrade ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.