Fixes #7038: No error when hostgroup name exceeds 245 characters #1701
Conversation
|
Tested and I'm getting message |
| max_length_for_name = self.send(:obj_type).length + 1 | ||
| max_length_for_name += parent.title.length unless parent.nil? | ||
|
|
||
| errors.add(:name, _("Maximum for this name is #{255 - max_length_for_name} characters")) if 255 - (name.length + max_length_for_name) < 0 |
There was a problem hiding this comment.
Note you can't put interpolation inside an extracted string (use %s etc), and errors for attributes should begin with a lower case letter so they read correctly when concatenated.
|
@orrabin can you please also make sure there are tests for the hostgroup name length. |
| max_length_for_name = self.send(:obj_type).length + 1 | ||
| max_length_for_name += parent.title.length unless parent.nil? | ||
|
|
||
| errors.add(:name, _("Maximum for this name is %s characters") % (255 - max_length_for_name)) if 255 - (name.length + max_length_for_name) < 0 |
There was a problem hiding this comment.
@domcleal changed to %s but the error is not concatenated with Name so I left the capital letter at the beginning
There was a problem hiding this comment.
It will be when rendered with full_messages (in the API I think), as you get..
> Hostgroup.new(:name => 'a' * 300).tap { |h| h.valid? }.errors.full_messages.to_sentence
=> "Title is too long (maximum is 255 characters) and Name Maximum for this name is 245 characters"
|
@tstrachota I fixed the double message and added some tests |
| max_length_for_name = self.send(:obj_type).length + 1 | ||
| max_length_for_name += parent.title.length unless parent.nil? | ||
|
|
||
| errors.add(:name, _("maximum for this name is %s characters") % (255 - max_length_for_name)) if 255 - (name.length + max_length_for_name) < 0 |
There was a problem hiding this comment.
@domcleal I fixed the error message
|
[test] |
This PR replaces #1686