fixes #7191 - move API response logger to named filter so it can be skipped #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -211,6 +209,10 @@ def setup_search_options | |||
| end | |||
| end | |||
|
|
|||
| def log_response_body | |||
| logger.debug "Body: #{response.body}" | |||
There was a problem hiding this comment.
👍
can we wrap the string in { } so it would be really executed unless in debug mode? similar to https://github.com/theforeman/foreman/blob/develop/app/services/report_importer.rb#L20
…t can be skipped
domcleal
force-pushed
the
7191-api-log-filter
branch
from
6393726
to
ac4dbd9
Compare
|
merged as 5c631b8, might consider it for 1.6 as it potentially boost api performance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be used like this: domcleal/foreman_bootdisk@843f0b4