Fixes #746 - Generate all the Host template when click on Build to avoid...

[shlomizadok]

Generate all the Host template when click on Build to avoid errors during installation.
Includes moving of template_used to Managed model so it can be used elsewhere.

[dLobatog]

Please refactor into a separate method available_template_kinds or something like that.

[dLobatog]

@shlomizadok There is some test that needs to be fixed and also the stuff I commented about.
Thanks for taking care of this one, we've been lacking this for 3 years no less. 😑

[shlomizadok]

@elobato Thanks for the review. I will fix your comments and fix the tests. I am also extending the 'review before build' to: a) return a better explanation of what failed (as you have also commented) and b) to test if the smart proxy is available before building.

[ohadlevy]

please extracte to a different PR

[lzap]

Nitpick: No newline :-D

[lzap]

Nice, I like that a lot. Do folks think it is good time to add the rendered templates to audit now? Or would it make sense to add all template rendering to audit in more generic way?

[ohadlevy]

you can avoid returning self if you change this line to

(@build = HostBuildStatus.new(@host)).host_build_status

another simple way, is to add a method on the host object similar to

def build_status
  build_status = HostBuildStatus.new(self)
  build_status.host_build_status # I would rename to method but thats another story
  build_status
end

[ohadlevy]

why in host common? I don't think it is used in hostgroup?

[mmoll]

tested (without a Compute Resource), works for me.
One thing I noted, when a proxy is not reachable, the mesage in the UI is:

Proxies
  Error connecting to smart.pro.xy: undefined method `to_sentence' for true:TrueClass.

[shlomizadok]

@mmoll - Thanks for testing. I have fixed the error message (though error handling on smart_proxy api should be re-factored too [but that is for another pr])

[ohadlevy]

add an explanation ?

[shlomizadok]

Don't think so. Should return true or false. The rescue is in cases the Proxy is unavailable.

[ohadlevy]

a tidy bit more optimized jquery could be:

 $(function () {
-  $("#build-review").click(function() {
-    $("#review_before_build .modal-body #build_status").html('');
+  var dialog = $("#review_before_build");
+  $("#build-review").click(function () {
+    dialog.find(".modal-body #build_status").html('');
     $('.loading').addClass('visible');
     $.ajax({
-      type:'get',
+      type: 'get',
       url: $(this).attr('data-url'),
-      success: function(result){
-       $("#review_before_build .modal-body #build_status").html(result);
+      success: function (result) {
+        $("#review_before_build").find(".modal-body #build_status").html(result);
       },
-      complete: function(){
+      complete: function () {
         $('.loading').removeClass('visible');
       }
-    })
+    });
   });
-  $('#review_before_build').on('change', "#host_build", function () {
+  dialog.on('change', "#host_build", function () {
     $('#build_form').find('input.submit').val((this.checked) ? (__("Reboot and build")) : (__("Build")));
   });

-  $('#review_before_build').on('click', "#recheck_review", function () {
+  dialog.on('click', "#recheck_review", function () {
     $("#build-review").click();
   });
 });

[shlomizadok]

@ohadlevy tidied the js, rebased and tests are 💚

[ohadlevy]

merged as 6e916e5 thanks @shlomizadok!