Fixes #2089 - Add network configuration to ENC

[ares]

No description provided.

[GregSutcliffe]

I'm not sure how well YAML (or at least the Puppet ENC) handles nil values for keys - should we consider not including nils in the ENC YAML?

[ares]

I'm not sure I follow. nil should never become key, subnets is always array of hashes and some values may be nil which becomes undef (well I tested only on one puppet version)

I'd say that it would be more convenient to always have gateway key which sometimes has address as a value and sometimes is undef. Some subnets does not have gateway which is valid value.

[GregSutcliffe]

To quote myself: "nil values for keys" - it's the values that are nil, not the keys. If they get correctly converted to undef then thats fine - we've strugged to pass undef in various places in the past, which is why I'm raising it

[ares]

It's "for keys" part that I didn't understand. Anyway if you get to same results I think undef is the best fit here.

[ares]

Do we want to convert Nic::Managed to Interface and Nic::Bond to Bond in interface type?
edit:
we do (not translated ofc), I'll reuse mapping that will be used in API

[ares]

@GregSutcliffe your comment was removed (EDIT: and is back again), but here's my answer - it works in development which tends to be issue with STI but since we have require_dependency for children in all NIC classes it should work fine

[GregSutcliffe]

@ares I don't think this loading @host.subnet correctly for the built-in interface:

  interfaces:
  - mac: 52:54:00:e0:bf:95
    ip: 192.168.123.2
    type: Interface
    name: 
    attrs: {}
    virtual: false
    link: true
    identifier: 
    managed: true
    subnet: 

The host definitely has a subnet:

[3] pry(main)> Host.find(745).subnet
  Host::Managed Load (0.8ms)  SELECT "hosts".* FROM "hosts" WHERE "hosts"."type" IN ('Host::Managed') AND "hosts"."id" = $1 LIMIT 1  [["id", 745]]
  Subnet Load (0.9ms)  SELECT "subnets".* FROM "subnets" WHERE "subnets"."id" = 6 ORDER BY vlanid LIMIT 1
=> #<Subnet id: 6, network: "192.168.123.0", mask: "255.255.255.0", priority: nil, name: "Static", vlanid: "", created_at: "2014-01-15 15:51:03", updated_at: "2014-01-15 15:51:03", dhcp_id: nil, tftp_id: nil, gateway: "192.168.123.1", dns_primary: "192.168.123.1", dns_secondary: "172.20.10.1", from: "", to: "", dns_id: nil, boot_mode: "Static", ipam: "DHCP">

[GregSutcliffe]

Reviewed, tested, looks great for my various networking test hosts. Merged as a1b2ee5, thanks!