Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #8837 - Return correctly formatted response on ajax_error #2049

Closed
wants to merge 1 commit into from

Conversation

tbrisker
Copy link
Member

@tbrisker tbrisker commented Jan 6, 2015

No description provided.

@dLobatog
Copy link
Member

dLobatog commented Jan 7, 2015

Merged as de3b8fe, thanks @tbrisker

I tested this by adding a process_ajax_error StandardError.new('sadasd'), 'fetch overview information' line at the beginning of hosts_controller : overview and visiting a Host page, then putting a breakpoint in the if(status == 'error') condition part of application.js. That's in the data-ajax-url fetching .each loop. It returns the right error status and message as JSON. I removed the logger.debug line to that prints the backtrace when testing.

@dLobatog dLobatog closed this Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants