Fixes #9045 - added reschedule_migrations seed script #2098
Conversation
| if User.anonymous_admin(false) && Puppetclass.count > 0 | ||
| User.current = User.anonymous_admin | ||
| Puppetclass.all.each(&:update_total_hosts) | ||
| else |
There was a problem hiding this comment.
Why not leave a message for the user with puts?
There was a problem hiding this comment.
Sure but it will end up in the Rails log. I think it's kinda useless. Do you happen to know how to display a nice message to the user?
There was a problem hiding this comment.
Added the puts anyway, won't hurt...
|
@lzap Rubocop is complaining, after that (and possibly the info message) 👍 |
dLobatog
added
Waiting on contributor
and removed
Not yet reviewed
Needs testing
labels
|
Would it be better to move the code somewhere common (like app/services/) instead of calling migrations from seeds? |
|
Which code? The three lines hack? Do you think it is worth a new service file? I don't think so. There is zero reusability there. |
lzap
force-pushed
the
migration-puppet-9045
branch
from
025e66b
to
4d779b2
Compare
|
Fixed Rubocop warning. |
|
I meant the contents of the rake task, but never mind, I thought you were calling that from db:seed, I see what's happening now. I'm really against merging this chaining of DB migrations from DB seeds. The upgrades that introduced the anonymous admin were back around Foreman 1.5/1.6, and the Puppet classes fix was around 1.7, so to merge this hack that's going to fire on every seed run is really not worth it at this point in time... |
|
@lzap , |
|
This is not outdated. Closing. |
This fixes the issue, but the drawback is it reschedules the puppetclass
correction after every single seed.
Alternative solution would be to create the anonymous admin if it's not present
directly in the codebase.