fixes #9296 - Ensure bond has a mac address of one of attached iface #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with the commit message:
Guidelines are available on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
…hed iface In order for some operations (like changing the IP address) of a bond to work, it must have a mac address. This ensures that a) a mac address is assigned, and b) that it belongs to one of the interfaces involved in the bond.
| @@ -6,6 +6,7 @@ class Bond < Managed | |||
| validates :attached_devices, :format => { :with => /\A[a-z0-9#{SEPARATOR}.:_-]+\Z/ }, :allow_blank => true | |||
|
|
|||
| before_save :ensure_virtual | |||
| after_save :ensure_mac | |||
There was a problem hiding this comment.
shouldn't this happen before validation?
|
A unit test for this feature would be appreciated. |
ares
changed the title
|
[test] because of the latest enabled cops |
|
@bcrochet any plans for further work on this PR? |
|
@ares I'm not sure this is the best approach anymore. Also, I'm not totally convinced that this is the fix for the behaviour that was identified in staypuft. So, I will close this for now. |
|
ok, thanks for info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for some operations (like changing the IP address) of a bond to
work, it must have a mac address. This ensures that a) a mac address is
assigned, and b) that it belongs to one of the interfaces involved in
the bond.