Fixes #10479 - prevent validation error on host creation when domain …

app/models/domain.rb

@@ -27,7 +27,7 @@ class Domain < ActiveRecord::Base
 
   accepts_nested_attributes_for :domain_parameters, :allow_destroy => true
   include ParameterValidators
-  validates :name, :presence => true, :uniqueness => true
+  validates :name, :presence => true, :uniqueness => { :case_sensitive => false }
   validates :fullname, :uniqueness => true, :allow_blank => true, :allow_nil => true
   validates :dns, :proxy_features => { :feature => "DNS", :message => N_('does not have the DNS feature') }
 

app/models/nic/base.rb

@@ -107,7 +107,7 @@ def name=(*args)
     end
 
     def shortname
-      domain.nil? ? name : name.to_s.chomp("." + domain.name)
+      domain.nil? ? name : name.to_s.sub(/\.#{Regexp.escape domain.name}\Z/i, '')
     end
 
     def validated?

app/models/nic/interface.rb

@@ -93,19 +93,19 @@ def normalize_name
       return if name.empty?
       if domain.nil? && name.include?('.') && !changed_attributes['domain_id'].present?
         # try to assign the domain automatically based on our existing domains from the host FQDN
-        self.domain = Domain.find_by(:name => name.partition('.')[2])
+        self.domain = Domain.where('LOWER(name) = ?', name.partition('.')[2].downcase).first
       elsif persisted? && changed_attributes['domain_id'].present?
         # if we've just updated the domain name, strip off the old one
-        old_domain = Domain.find(changed_attributes["domain_id"])
+        old_domain = Domain.where(:id => changed_attributes["domain_id"]).pluck(:name).first
         # Remove the old domain, until fqdn will be set as the full name
-        self.name.chomp!("." + old_domain.to_s)
+        self.name.sub!(/\.#{Regexp.escape old_domain}/i, '')
       end
       # name should be fqdn
       self.name = fqdn
       # A managed host we should know the domain for; and the shortname shouldn't include a period
       # This only applies for unattended=true, as otherwise the name field includes the domain
       errors.add(:name, _("must not include periods")) if ( host && host.managed? && managed? && shortname.include?(".") && SETTINGS[:unattended] )
-      self.name = Net::Validations.normalize_hostname(name) if self.name.present?
+      self.name = Net::Validations.normalize_hostname(name)
     end
   end
 end

db/migrate/20150921090740_add_index_to_domain_name.rb

@@ -0,0 +1,16 @@
+class AddIndexToDomainName < ActiveRecord::Migration
+  def up
+    case ActiveRecord::Base.connection.instance_values["config"][:adapter]
+    when "postgresql"
+      execute 'CREATE UNIQUE INDEX domain_name_index ON domains (lower(name))'
+    when "sqlite3"
+      execute 'CREATE UNIQUE INDEX domain_name_index ON domains (name collate nocase)'
+    else
+      add_index :domains, :name, :name => 'domain_name_index', :unique => true
+    end
+  end
+
+  def down
+    remove_index! :domains, 'domain_name_index'
+  end
+end

test/unit/domain_test.rb

@@ -16,6 +16,14 @@ def setup
   should validate_uniqueness_of(:fullname).allow_nil
   should validate_uniqueness_of(:fullname).allow_blank
 
+  test "should have a unique case-insensitive name" do
+    other_domain = Domain.new(:name => @domain.name.upcase)
+    refute other_domain.save
+    assert_raises ActiveRecord::RecordNotUnique, ActiveRecord::StatementInvalid do
+      other_domain.save(:validate => false) #make sure the DB enforces this
+    end
+  end
+
   test "when cast to string should return the name" do
     s = @domain.to_s
     assert_equal @domain.name, s

test/unit/nics/managed_test.rb

@@ -43,6 +43,14 @@ class ManagedTest < ActiveSupport::TestCase
     assert_nil nic.domain
   end
 
+  test "#normalize_hostname accepts domain even if it contains capital letters" do
+    domain = FactoryGirl.create(:domain, :name => "CAPITAL.com")
+    nic = setup_primary_nic_with_name(" Host.#{domain.name}", :domain => nil)
+    nic.send(:normalize_name)
+    assert_equal "host.#{domain.name.downcase}", nic.name
+    assert_equal domain, nic.domain
+  end
+
   test "#normalize_hostname keeps domain nil if it can't find such domain based on name" do
     nic = setup_primary_nic_with_name(" Host", :domain => nil)
     nic.send(:normalize_name)