Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #10439 - Made trends:reduce task idempotent #2379

Closed
wants to merge 1 commit into from
Closed

Fixes #10439 - Made trends:reduce task idempotent #2379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
73 changes: 73 additions & 0 deletions test/lib/tasks/trends_test.rb
View file
Open in desktop
Expand Up @@ -6,6 +6,7 @@ class TrendsTest < ActiveSupport::TestCase
Rake.application.rake_require 'tasks/trends'
Rake::Task.define_task(:environment)
Rake::Task['trends:reduce'].reenable
Rake::Task['trends:clean'].reenable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought we wanted to get rid of the clean task? is it needed anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll put it in a different PR. Without this line the tests will fail.


TrendCounter.unscoped.delete_all
Trend.unscoped.delete_all
Expand Down Expand Up @@ -104,6 +105,78 @@ class TrendsTest < ActiveSupport::TestCase
end
end

test 'trends:reduce can rerun with additional datapoint with the same value' do
os_trend = FactoryGirl.create(:foreman_trends, :operating_system)
os_point_dates = create_trend_line(os_trend, [1,1,1,1,1,1])
Rake.application.invoke_task 'trends:reduce'

interval = TrendCounter.where(trend_id: os_trend.id).order(:interval_start).to_a
assert_equal 1, interval.length
interval = interval.first

FactoryGirl.create(:trend_counter, :trend => os_trend, :created_at => os_point_dates[3], :updated_at => os_point_dates[3], :count => 1)

Rake::Task['trends:reduce'].reenable
Rake.application.invoke_task 'trends:reduce'

new_interval = TrendCounter.where(trend_id: os_trend.id).order(:interval_start).to_a
assert_equal 1, new_interval.length
new_interval = new_interval.first

assert_equal new_interval, interval
end

test 'trends:reduce can rerun with additional datapoint with different value in open interval' do
os_trend = FactoryGirl.create(:foreman_trends, :operating_system)
os_point_dates = create_trend_line(os_trend, [1,1,1,1,1,1])
Rake.application.invoke_task 'trends:reduce'

interval = TrendCounter.where(trend_id: os_trend.id).order(:interval_start).to_a
assert_equal 1, interval.length

FactoryGirl.create(:trend_counter, :trend => os_trend, :created_at => os_point_dates[3], :updated_at => os_point_dates[3], :count => 2)

Rake::Task['trends:reduce'].reenable
Rake.application.invoke_task 'trends:reduce'

new_intervals = TrendCounter.where(trend_id: os_trend.id).order(:interval_start).to_a
assert_equal 2, new_intervals.length

assert_equal 1, new_intervals[0].count
assert_equal 2, new_intervals[1].count

assert_equal os_point_dates[0], new_intervals[0].interval_start
assert_equal os_point_dates[3], new_intervals[0].interval_end
assert_equal os_point_dates[3], new_intervals[1].interval_start
end

test 'trends:reduce can rerun with additional datapoint with different value in closed interval' do
os_trend = FactoryGirl.create(:foreman_trends, :operating_system)
os_point_dates = create_trend_line(os_trend, [1,1,1,1,1,2])
Rake.application.invoke_task 'trends:reduce'

interval = TrendCounter.where(trend_id: os_trend.id).order(:interval_start).to_a
assert_equal 2, interval.length

FactoryGirl.create(:trend_counter, :trend => os_trend, :created_at => os_point_dates[3], :updated_at => os_point_dates[3], :count => 3)

Rake::Task['trends:reduce'].reenable
Rake.application.invoke_task 'trends:reduce'

new_intervals = TrendCounter.where(trend_id: os_trend.id).order(:interval_start).to_a
assert_equal 3, new_intervals.length

assert_equal 1, new_intervals[0].count
assert_equal 3, new_intervals[1].count
assert_equal 2, new_intervals[2].count

assert_equal os_point_dates[0], new_intervals[0].interval_start
assert_equal os_point_dates[3], new_intervals[0].interval_end
assert_equal os_point_dates[3], new_intervals[1].interval_start
assert_equal os_point_dates[5], new_intervals[1].interval_end
assert_equal os_point_dates[5], new_intervals[2].interval_start
end

test 'trends:clean' do
trend = FactoryGirl.create(:foreman_trends, :operating_system)
created_at = Time.now
Expand Down