fixes #10336 - move rbvmomi CR loading before our CR loading #2382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test this simply by starting Rails and the warning message about Rbvmomi and ComputeResource should disappear. |
|
👍 |
|
@domcleal - we should hook jenkins if the failure is deadlock, it should re-run [test] automatically :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores the old #2680 workaround, which might also have been causing #9779 and has also been printing out the warning message recently (whose purpose was to warn about this potential bug). #4478 added a reference to ComputeResource in an earlier initialiser, which changed the load order.