fixes #10232 - moving validations and casting out of lookup key and value #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please check the rubocop and unit test failures, thanks. |
unorthodoxgeek
force-pushed
the
10232-move-validations-and-casting
branch
from
04549a6
to
6e343a5
Compare
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
unorthodoxgeek
force-pushed
the
10232-move-validations-and-casting
branch
from
6e343a5
to
28b7bed
Compare
| context "failues" do | ||
| test "caster cowardly doesn't make any change in case it doesn't know how to cast" do | ||
| item = OpenStruct.new(:foo => "blah") | ||
| #assert_raises TypeError do |
|
@ares would you mind giving this look over, since you've spent some time in this area? It looks minimally invasive to me, just moving code rather than behavioural changes. |
| @@ -0,0 +1,118 @@ | |||
| module Parameters | |||
There was a problem hiding this comment.
Could we put this under the Foreman namespace too? e.g. Foreman::Parameters::Caster
unorthodoxgeek
force-pushed
the
10232-move-validations-and-casting
branch
from
28b7bed
to
cc1a85e
Compare
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
| module Parameters | ||
| class Caster | ||
| TRUE_VALUES = [true, 1, '1', 't', 'T', 'true', 'TRUE', 'on', 'ON', 'yes', 'YES', 'y', 'Y'].to_set | ||
| FALSE_VALUES = [false, 0, '0', 'f', 'F', 'false', 'FALSE', 'off', 'OFF', 'no', 'NO', 'n', 'N'].to_set |
|
Please note that not all of my previous comments were addressed. |
| @@ -214,7 +207,7 @@ def array2path(array) | |||
| def validate_and_cast_default_value | |||
There was a problem hiding this comment.
Misnamed, should be cast only.
unorthodoxgeek
force-pushed
the
10232-move-validations-and-casting
branch
from
f368890
to
942ca23
Compare
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
@domcleal - fixed your comments |
unorthodoxgeek
force-pushed
the
10232-move-validations-and-casting
branch
from
942ca23
to
19a989c
Compare
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
| @@ -6,6 +6,7 @@ | |||
| factory :environment_class | |||
|
|
|||
| factory :lookup_key do | |||
| key_type "string" | |||
orrabin
force-pushed
the
10232-move-validations-and-casting
branch
from
19a989c
to
93c64c4
Compare
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
… key and value
orrabin
force-pushed
the
10232-move-validations-and-casting
branch
from
93c64c4
to
a07a28a
Compare
|
@domcleal I rebased and fixed the factory. |
|
Merged as 9f88e8a, thanks @unorthodoxgeek and @orrabin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.