Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #10021 - config groups are now taxable #2416

Closed
wants to merge 1 commit into from

Conversation

ohadlevy
Copy link
Member

requires testing

@domcleal
Copy link
Contributor

domcleal commented Jun 1, 2015

Unit tests and rubocop are failing.

@ohadlevy
Copy link
Member Author

ohadlevy commented Jun 1, 2015

@domcleal tests pass now

@ohadlevy
Copy link
Member Author

ohadlevy commented Jun 2, 2015

@domcleal ping

@dLobatog
Copy link
Member

dLobatog commented Jun 2, 2015

@ohadlevy Are the permissions checked on ConfigGroups#index? I can assign one config group to organization 'foo' and another to organization 'bar' yet I see both on the list when I'm scoped to only see 'foo', or 'bar'.

Similarly on Host#new, it seems useless to choose a organization to limit config groups? Neither choosing an organization on the form nor scoping my session to a organization limits the config groups shown in the Puppet tab.

@tbrisker
Copy link
Member

@ohadlevy,
Thank you very much for your efforts!
This PR has been open for a very long time with no activity.
Please indicate if you plan to continue working on it or not; if not, feel free to close it.
If you do not respond either way within a couple of weeks, I will assume this PR is abandoned and will go ahead and close it for you.

@ohadlevy
Copy link
Member Author

@tbrisker thanks for the kind reminder - I'm not planning to work on it, if anyone else wishes he may use this as a starting point - thanks

@ohadlevy ohadlevy closed this Mar 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants