Fixes #10664 - map only physical interfaces in compute orchestration #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
|
👍 it fixes the issue. I know it's difficult to test the code around orchestration and it requires quite some mocking but would you mind adding a test for the behaviour to |
|
added tests, @tstrachota let me know if I should change PR flags |
|
Thanks, @ares. Ready to merge from my point of view. |
|
[test] , it timed out for some reason |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tstrachota could you please review? Maybe the compute attributes should not only be hidden but also disabled in the UI. Anyway, this seems to fix the issue for me.