Fixes #7840 - Show correct values for smart variables on host edit page #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbrisker
changed the title
|
[test] random katello failure |
domcleal
added
Not yet reviewed
Needs testing
and removed
Waiting on contributor
labels
|
@tbrisker Sorry, I can't reproduce this neither with Smart Variables nor with Class Parameters. I set them to be overridden for an specific fqdn, then when I go to the host, I click on the Parameters tab, and check the value of the parameters, and it's the overridden value for both of them. This is in the current develop branch. Would you mind to check back and see if this is fixed in develop or am I testing it wrong? |
dLobatog
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
|
@elobato This happens when the override matcher is anything other then fqdn. Try adding a matcher for the domain. |
domcleal
added
Not yet reviewed
Needs testing
and removed
Waiting on contributor
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.