Fixes #10879 - improved reports widget performance #2478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Our patch for the widget is basically termorary until this is merged: wvanbergen/scoped_search#132 |
|
FYI, I intend to just close this PR once a new scoped_search is released, we'll simply inherit the bug fix from your work there. |
|
Thanks @lzap! |
|
Belatedly, I notice that you're including a DB migration here to make the column non-null, reopening. |
| @@ -59,8 +59,8 @@ def searchable_links(name, search, counter) | |||
| end | |||
|
|
|||
| def latest_events | |||
| # 6 reports + header fits the events box nicely... | |||
| Report.authorized(:view_reports).my_reports.interesting.search_for('reported > "7 days ago"').limit(6).includes(:host) | |||
| # scoped_search generates unoptimized query until this is fixed: https://github.com/wvanbergen/scoped_search/pull/132 | |||
There was a problem hiding this comment.
This file's changes can be reverted now.
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
Sure, rebased! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and made created_at column non-NULL to prevent from other expensive queries
with "NULLS FIRST" or "NULLS LAST". This is being added by scoped_search.