fixes #10985 - Set css class for width of filter select on puppetca#index #2511

shlomizadok · 2015-07-02T14:56:37Z

Please note that at some point we will refactor this page to work with javascript filtering

theforeman-bot · 2015-07-02T14:56:39Z

There were the following issues with the commit message:

e98c4b3 must be in the format Fixes/refs #redmine_number - brief description.

Guidelines are available on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

shlomizadok · 2015-07-05T10:32:49Z

per @ohadlevy idea, moved those fields to use data-tables

ohadlevy · 2015-07-05T10:33:58Z

app/controllers/puppetca_controller.rb

@@ -4,7 +4,7 @@ def index
    # expire cache if forced
    Rails.cache.delete("ca_#{@proxy.id}") if params[:expire_cache] == "true"
    certs = find_certs
-    @certificates = certs.sort.paginate :page => params[:page], :per_page => Setting::General.entries_per_page
+    @certificates = certs.sort


maybe we should apply client side sorting instead?

The previous behavior was that they arrive sorted (sort from the server) and the can be re-sorted on the client

yes i understand, imho you should set the default sort on the js side now, as it has no knowledge on which field sorting was done

shlomizadok · 2015-07-05T12:20:03Z

app/assets/javascripts/application.js

@@ -77,7 +77,8 @@ function onContentLoad(){
  $('[data-table=inline]').not('.dataTable').dataTable(
      {
        "sDom": "<'row'<'col-md-6'f>r>t<'row'<'col-md-6'i><'col-md-6'p>>",
-        "sPaginationType": "bootstrap"
+        "sPaginationType": "bootstrap",
+        "order": [[ 0, 'asc' ]] // Set default order for the first column


This will sort each data-table with the first column (usually name)

Left this on this PR even though not using data-tables (as it is a good practice to have default sort)

domcleal · 2015-07-07T13:50:43Z

app/controllers/puppetca_controller.rb

@@ -3,8 +3,7 @@ def index
    @proxy = find_proxy
    # expire cache if forced
    Rails.cache.delete("ca_#{@proxy.id}") if params[:expire_cache] == "true"
-    certs = find_certs
-    @certificates = certs.sort.paginate :page => params[:page], :per_page => Setting::General.entries_per_page
+    @certificates = find_certs


This method returns only valid and pending certificates by default, then it used to be possible to select "revoked" from the dropdown (in theory) to view revoked certs too. I can't see how to do this now? Also, the find_certs method still uses params[:state] which is no longer set.

Removed find_certs method and now returning all certs. Filtering is done only on the client side. Seems reasonable?

ohadlevy · 2015-07-08T06:55:35Z

@shlomizadok imho the usability here is worse, its hard to filter, and at first glance you lose visibility.

by default imho, the user is looking for pending certs (else why go there), sorting based on name is useless if you have uuid for certnames.

i wonder if there is a way to keep the old drop down, and apply it via search to data-table or something that will keep the old ux and improve the client side sorting.

domcleal · 2015-07-08T11:48:03Z

So why the suggestion that it should move to the JS table impl if we lose the filtering feature in the process? We're moving further and further from fixing the original bug it appears.

shlomizadok · 2015-07-15T08:20:27Z

Reverted back the changes to autosign controller & view.
Reverted back to setting min-width, bootstrap class did not play well

domcleal · 2015-07-15T09:21:16Z

app/assets/javascripts/application.js

@@ -77,7 +77,8 @@ function onContentLoad(){
  $('[data-table=inline]').not('.dataTable').dataTable(
      {
        "sDom": "<'row'<'col-md-6'f>r>t<'row'<'col-md-6'i><'col-md-6'p>>",
-        "sPaginationType": "bootstrap"
+        "sPaginationType": "bootstrap",


domcleal · 2015-07-15T09:26:04Z

Is the multi-line layout deliberate? If so, it could probably do with a bit of padding between the select and table.

shlomizadok · 2015-07-15T09:31:06Z

Weird, this does not happen to on chrome

Nor on Firefox

Will remove the unused stuff

domcleal · 2015-07-15T09:45:50Z

I think it's probably due to mark_translated then which makes the text a little longer. Is the width of that text container limited precisely to the length of the English text? If so then it's going to wrap in any language where "Filter by state" translates to a slightly longer string.

shlomizadok · 2015-07-15T10:20:34Z

the text container is not limited, the <div> above is :/
I can wrap the text also in a div, so with long text it would look like:

Looks reasonable?

(though, to be honest, I don't understand why we give so little space on https://github.com/theforeman/foreman/blob/develop/app/views/layouts/application.html.erb#L13 [col-md-4])

shlomizadok · 2015-07-15T10:37:00Z

I'm sorry - I'll just give a little less space to the select list, so it will look like that:

(Deutsch is the longest language I've found 😉 )

shlomizadok · 2015-07-15T12:16:18Z

re[test] - RKF

shlomizadok · 2015-07-15T16:38:31Z

[test]

domcleal · 2015-07-16T09:56:51Z

Merged as befd671, thanks @shlomizadok.

theforeman-bot added Waiting on contributor Not yet reviewed Needs testing labels Jul 2, 2015

domcleal removed the Not yet reviewed label Jul 2, 2015

shlomizadok changed the title ~~fix #10985 - Add width to puppet ca filter select~~ fixes #10985 - Add width to puppet ca filter select Jul 5, 2015

shlomizadok force-pushed the fix_10985 branch from e98c4b3 to a644089 Compare July 5, 2015 09:35

theforeman-bot added Needs re-review Needs testing and removed Waiting on contributor labels Jul 5, 2015

shlomizadok force-pushed the fix_10985 branch from a644089 to 88b0bc6 Compare July 5, 2015 10:31

ohadlevy reviewed Jul 5, 2015
View reviewed changes

shlomizadok force-pushed the fix_10985 branch from 88b0bc6 to 471ea6a Compare July 5, 2015 12:18

shlomizadok reviewed Jul 5, 2015
View reviewed changes

domcleal added the 1.9.0 priority label Jul 6, 2015

domcleal reviewed Jul 7, 2015
View reviewed changes

domcleal changed the title ~~fixes #10985 - Add width to puppet ca filter select~~ fixes #10985 - Use dataTables on puppetca#index and autosign#index Jul 7, 2015

domcleal added Waiting on contributor and removed 1.9.0 priority Needs re-review labels Jul 7, 2015

shlomizadok force-pushed the fix_10985 branch from 471ea6a to e9ccb02 Compare July 8, 2015 06:23

theforeman-bot added Needs re-review Needs testing and removed Waiting on contributor labels Jul 8, 2015

domcleal added Waiting on contributor and removed Needs re-review labels Jul 9, 2015

shlomizadok force-pushed the fix_10985 branch from e9ccb02 to 59c434e Compare July 9, 2015 15:28

domcleal reviewed Jul 15, 2015
View reviewed changes

domcleal added Waiting on contributor and removed Needs re-review labels Jul 15, 2015

shlomizadok force-pushed the fix_10985 branch from c4e3a7d to 24ee707 Compare July 15, 2015 09:32

theforeman-bot added Needs re-review Needs testing and removed Waiting on contributor labels Jul 15, 2015

domcleal added Waiting on contributor and removed Needs re-review labels Jul 15, 2015

shlomizadok force-pushed the fix_10985 branch from 24ee707 to b083bad Compare July 15, 2015 10:37

theforeman-bot added Needs re-review Needs testing and removed Waiting on contributor labels Jul 15, 2015

fixes #10985 - Set css class for width of filter select

5406b83

shlomizadok force-pushed the fix_10985 branch from b083bad to 5406b83 Compare July 16, 2015 06:36

domcleal added Ready to merge and removed Needs re-review Needs testing labels Jul 16, 2015

domcleal closed this Jul 16, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes #10985 - Set css class for width of filter select on puppetca#index #2511

fixes #10985 - Set css class for width of filter select on puppetca#index #2511

shlomizadok commented Jul 2, 2015

theforeman-bot commented Jul 2, 2015

shlomizadok commented Jul 5, 2015

ohadlevy Jul 5, 2015

shlomizadok Jul 5, 2015

ohadlevy Jul 5, 2015

shlomizadok Jul 5, 2015

shlomizadok Jul 9, 2015

domcleal Jul 7, 2015

shlomizadok Jul 8, 2015

ohadlevy commented Jul 8, 2015

domcleal commented Jul 8, 2015

shlomizadok commented Jul 15, 2015

domcleal Jul 15, 2015

domcleal commented Jul 15, 2015

shlomizadok commented Jul 15, 2015

domcleal commented Jul 15, 2015

shlomizadok commented Jul 15, 2015

shlomizadok commented Jul 15, 2015

shlomizadok commented Jul 15, 2015

shlomizadok commented Jul 15, 2015

domcleal commented Jul 16, 2015

fixes #10985 - Set css class for width of filter select on puppetca#index #2511

fixes #10985 - Set css class for width of filter select on puppetca#index #2511

Conversation

shlomizadok commented Jul 2, 2015

theforeman-bot commented Jul 2, 2015

shlomizadok commented Jul 5, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ohadlevy commented Jul 8, 2015

domcleal commented Jul 8, 2015

shlomizadok commented Jul 15, 2015

Choose a reason for hiding this comment

domcleal commented Jul 15, 2015

shlomizadok commented Jul 15, 2015

domcleal commented Jul 15, 2015

shlomizadok commented Jul 15, 2015

shlomizadok commented Jul 15, 2015

shlomizadok commented Jul 15, 2015

shlomizadok commented Jul 15, 2015

domcleal commented Jul 16, 2015