Fixes #11413 - disable SQL logging by default

[tbrisker]

No description provided.

[dLobatog]

I think that if you want to change the default maybe config/logging.yaml is a better option. I'd recommend adding config/logging.yaml to the .gitignore and shipping a logging.yml.example as we do with settings and database. That way everyone can have their own option easily.

[tbrisker]

@elobato I think this should be the default for rake, I've seen a couple of users already on IRC that missed the admin password because of this, and it also hides any errors when running migrations or tests. Note that if someone enables sql logging in the config it will still take precedence due to the reverse_merge, but if it isn't manually set I think the default should be off for rake and on for rails.

[domcleal]

logging.yaml shouldn't really be used to enable/disable individual loggers though, that's what SETTINGS is for. I'd suggest just turning off SQL logging by default, it was done this way because it matched previous behaviour, but it ought to be off by default like other debug-level stuff (LDAP, permissions).

[dLobatog]

Alright, set :sql => { :enabled => false } then and we close this off.

[domcleal]

And update the settings.yaml.example to match, please.

[tbrisker]

@elobato @domcleal I updated this as requested.

[domcleal]

Yes, it has the re-review label already. There are a lot of PRs.

[domcleal]

Merged as a683aa2, thanks @tbrisker.