Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #11034 - custom uniqueness validations for interface attributes #2672

Closed
wants to merge 1 commit into from

Conversation

ares
Copy link
Member

@ares ares commented Sep 4, 2015

No description provided.

@domcleal
Copy link
Contributor

domcleal commented Sep 8, 2015

Please note that the PR introduces many test failures.

@ares
Copy link
Member Author

ares commented Sep 15, 2015

[test], Katello failures seems unrelated

private

def interface_attribute_uniqueness(attr, base = Nic::Base.scoped)
in_memory_candidates = self.host.present? ? self.host.interfaces.select { |i| i.persisted? && !i.marked_for_destruction? } : [self]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat and readable 😄

@dLobatog
Copy link
Member

Merged as 12f3859, thanks @ares!

@dLobatog dLobatog closed this Sep 16, 2015
@ares ares deleted the fix/11034 branch September 16, 2015 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants