Fixes #11692: update ace-rails-ap to 4.x. #2698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given v4 precompiles the worker files, should they be removed from our assets? |
|
And talking of precompilation, there appears to be duplication between the app.js and the precompiled files which isn't necessary - see my ticket comments. |
|
@domcleal sorry, somehow I missed that comment, updated. |
|
@domcleal I believe I have addressed all comments. |
domcleal
added
Needs re-review
Ready to merge
and removed
Not yet reviewed
Needs re-review
Needs testing
labels
|
Merged as 4901dd3, thanks @waldenraines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://projects.theforeman.org/issues/11692