Fixes #11767 - set interface[:id] to nil only if it exists #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -729,7 +729,7 @@ def clean_interfaces_attributes | |||
| attributes = params[:host].dup | |||
| if params[:host][:interfaces_attributes] | |||
| attributes[:interfaces_attributes] = params[:host][:interfaces_attributes].dup.except(:created_at, :updated_at, :attrs) | |||
| attributes[:interfaces_attributes][:id] = nil | |||
| attributes[:interfaces_attributes][:id] = nil if attributes[:interfaces_attributes][:id] | |||
There was a problem hiding this comment.
It'd be fine to add this above as .dup.except(:id, :created_at, :updated_at, :attrs)
|
@shlomizadok Thanks! Can you add a test to make sure we don't get any regressions in this area? |
dLobatog
added
Waiting on contributor
and removed
Needs testing
Not yet reviewed
labels
|
This patch would help fix mass assignment exception but wouldn't with resolving the templates. IDs of nested interfaces are still present so when you add new interface and resolve a template, we'd get |
|
For an alternative fix see #2713 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why
attributes[:interfaces_attributes][:id] = nilis needed in the first place though