fixes #11833 - remove puppet references from config status #2725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stbenjam
force-pushed
the
11833
branch
5 times, most recently
from
f1e9141
to
7e62a58
Compare
|
It would be much appreciated if this could make 1.10. I broke out the more substantial but less critical part about settings names to #2726 |
| @@ -266,6 +266,15 @@ def teardown | |||
| refute host.primary_interface.managed? | |||
| end | |||
|
|
|||
| test "#configuration? returns true when host has puppetmaster" do | |||
| host = FactoryGirl.create(:host) | |||
There was a problem hiding this comment.
do we have to save the record? I think .build should be enough here and for smart proxy as well (which will save some time)
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.